[chore] generate Kubernetes manifests (part 1) #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
Signed-off-by: Pierre Tessier <[email protected]>
puckpuck
changed the title
fatsheep9146
approved these changes
Mar 11, 2023
|
Changelog needed ? |
Next PR will have the changelog |
styblope
pushed a commit
to instana/opentelemetry-demo
that referenced
this pull request
Mar 12, 2023
* generate kubernetes manifests Signed-off-by: Pierre Tessier <[email protected]> * add generated k8s manifest to yamlignore Signed-off-by: Pierre Tessier <[email protected]> * remove manifest to setup yamllint Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Carter Socha <[email protected]>
mat-rumian
pushed a commit
to SumoLogic/opentelemetry-demo
that referenced
this pull request
Mar 20, 2023
* generate kubernetes manifests Signed-off-by: Pierre Tessier <[email protected]> * add generated k8s manifest to yamlignore Signed-off-by: Pierre Tessier <[email protected]> * remove manifest to setup yamllint Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Carter Socha <[email protected]>
juliangiuca
pushed a commit
to juliangiuca/opentelemetry-demo
that referenced
this pull request
Apr 12, 2023
* generate kubernetes manifests Signed-off-by: Pierre Tessier <[email protected]> * add generated k8s manifest to yamlignore Signed-off-by: Pierre Tessier <[email protected]> * remove manifest to setup yamllint Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Carter Socha <[email protected]>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* generate kubernetes manifests Signed-off-by: Pierre Tessier <[email protected]> * add generated k8s manifest to yamlignore Signed-off-by: Pierre Tessier <[email protected]> * remove manifest to setup yamllint Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Carter Socha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545
Uses
helm template ...to generate the Kubernetes manifests. sed commands are added to remove Helm-specific annotations. Generation of the manifests is built into a make command. This will require some maintenance on our side to update the kubernetes manifests after Helm updates are made (perhaps we can automate this with a GHA)With this users can run
kubectl apply -f kubernetes/opentelemetry-demo.yamlto install the demo without Helm.This is part 1 or 2 for this PR. This PR adds the required logic to the Makefile, and sets up yamllint to work properly for the next PR which will add the actual manifest.
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.